Simplify and strengthen rotate_facial_area #1047
Conversation
|
|
||
| # Normalize the witdh of the angle so we don't have to | ||
| # worry about rotations greater than 360 degrees | ||
| angle = angle % 360 |
There was a problem hiding this comment.
angle will be positive always because of the module, so you can get rid of the direction because it will be 1 always
There was a problem hiding this comment.
That's not right.
75 % 360 == 75
-75 % 360 == -75
There was a problem hiding this comment.
This is my experiment.
Python 3.9.16 (main, Jan 11 2023, 16:05:54)
[GCC 11.2.0] :: Anaconda, Inc. on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> a = -75
>>> a % 360
285
>>>
>>>
>>> b = 75
>>> b % 360There was a problem hiding this comment.
still, both outputs will work as is
never mind this
There was a problem hiding this comment.
Ouch ... python mod operator is pretty fucked up. Every other language and calculators keeps the sign of dividend not the divisor.
|
Would you please run this code and share its output here import matplotlib.pyplot as plt
img_paths = ["dataset/dataset/img11.jpg", "dataset/img11_reflection.jpg"]
for img_path in img_paths:
results = DeepFace.extract_faces(img_path = img_path)
img = results[0]["face"]
plt.imshow(img)
plt.show() |
|
When I perform current implementation for dataset/img11_reflection.jpg, it is output is shown below - this is not correct! This is sorted when i set direction to 1 by default
|
|
Just pushed a change which should correct the error.
|
|
It is the output for img11.jpg, I wonder the output of img11_reflection.jpg also. |
|
Yep ... sorry
|
This strengthen
rotate_facial_areaby :angle: positive values for clockwise, negative for anti-clockwiseIn previous implementation direction could be any number causing unwanted results.
Also fixes #1045