Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tokio-tungstenite to 0.19 #2522

Merged
merged 1 commit into from
Aug 27, 2023

Conversation

tazz4843
Copy link
Contributor

@tazz4843 tazz4843 commented Aug 27, 2023

See commit message for better description

Closes #2517

Extra boolean parameter toggles Nagle's algorithm.
As far as I can tell, serenity has no use for this,
and disabling it should have no major effect.
@github-actions github-actions bot added the gateway Related to the `gateway` module. label Aug 27, 2023
@tazz4843
Copy link
Contributor Author

Looks like the "Check minimal versions" failure is unrelated? dtolnay/proc-macro2#398

@arqunis arqunis added enhancement An improvement to Serenity. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users dependencies Related to Serenity dependencies. labels Aug 27, 2023
@arqunis arqunis merged commit d779757 into serenity-rs:next Aug 27, 2023
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Sep 21, 2023
Extra boolean parameter toggles Nagle's algorithm. As far as I can tell,
Serenity has no use for this, and disabling it should have no major effect.
@tazz4843 tazz4843 deleted the update-tokio-tungstenite branch October 7, 2023 01:40
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 17, 2023
Extra boolean parameter toggles Nagle's algorithm. As far as I can tell,
Serenity has no use for this, and disabling it should have no major effect.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 24, 2023
Extra boolean parameter toggles Nagle's algorithm. As far as I can tell,
Serenity has no use for this, and disabling it should have no major effect.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
Extra boolean parameter toggles Nagle's algorithm. As far as I can tell,
Serenity has no use for this, and disabling it should have no major effect.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
Extra boolean parameter toggles Nagle's algorithm. As far as I can tell,
Serenity has no use for this, and disabling it should have no major effect.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users dependencies Related to Serenity dependencies. enhancement An improvement to Serenity. gateway Related to the `gateway` module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants