voice: use xsalsa20poly1305 crate for encryption
#884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arqunis
added
enhancement
tarcieri
commented
Jun 11, 2020
FelixMcFelix
requested changes
Jun 11, 2020
There was a problem hiding this comment.
Thanks for the PR, looks good (and should remove occasional external library issues to boot).
Other than a few nits, it's a welcome change; API mostly matches libsodium (including in-place/detached modes, which we're using in the rewrite, so we can migrate that too). I don't believe this is a breaking change since the crate is entirely internal, and the minimum compiler version is now below current's 1.39. Will test manually in the morning since CI for examples is broken on current.
This commit replaces the `sodiumoxide` crate, a wrapper for the libsodium C library, with the pure Rust `xsalsa20poly1305` crate from the RustCrypto project: https://github.com/RustCrypto/AEADs/tree/master/xsalsa20poly1305 This should reduce compile times as `libsodium` is a somewhat large C library and you are only using one algorithm from it. The `xsalsa20poly1305` crate, on the other hand, is a lightweight pure Rust dependency that implements only the algorithm you are using. Note that the advertised MSRV of this crate is 1.41+, however earlier today new release of the dependency causing that, `generic-array`, reduced the MSRV to 1.36.0: fizyk20/generic-array#102 You can read more about RustCrypto and our recent releases in this post: https://www.reddit.com/r/rust/comments/h0em5n/ann_new_rustcrypto_releases_aead_blockcipher/
FelixMcFelix
approved these changes
Jun 12, 2020
|
Tested locally, runs fine for me. Thanks! |
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Jun 12, 2020
…#884) This commit replaces the `sodiumoxide` crate, a wrapper for the libsodium C library, with the pure Rust `xsalsa20poly1305` crate from the RustCrypto project: https://github.com/RustCrypto/AEADs/tree/master/xsalsa20poly1305
FelixMcFelix
added a commit
to FelixMcFelix/serenity
that referenced
this pull request
Jun 12, 2020
This uses the `encrypt/decrypt_in_place` functions exposed by this library. Migration occurred due to decisions outlined in serenity-rs#884.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces the
sodiumoxidecrate, a wrapper for the libsodium C library, with the pure Rustxsalsa20poly1305crate from the RustCrypto project:https://github.com/RustCrypto/AEADs/tree/master/xsalsa20poly1305
This should reduce compile times as
libsodiumis a somewhat large C library and you are only using one algorithm from it. Thexsalsa20poly1305crate, on the other hand, is a lightweight pure Rust dependency that implements only the algorithm you are using.Note that the advertised MSRV of this crate is 1.41+, however earlier today new release of the dependency causing that,
generic-array, reduced the MSRV to 1.36.0:fizyk20/generic-array#102
You can read more about RustCrypto and our recent releases in this post:
https://www.reddit.com/r/rust/comments/h0em5n/ann_new_rustcrypto_releases_aead_blockcipher/