Abstract CommandResult type #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommandResult currently hardcodes to returning a Result with type (). Doing this limits the usability of CommandResult since users can't use this type alias with functions that return Results that don't use type (). Since Rust has type defaults, abstract CommandResult to accept type T with a default type of () which doesn't compromise the existing usage of CommandResult, but adds onto it. Signed-off-by: kingbri <bdashore3@gmail.com>
arqunis
approved these changes
Aug 20, 2020
arqunis
added
enhancement
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Nov 9, 2020
CommandResult currently hardcodes to returning a Result with type (). Doing this limits the usability of CommandResult since users can't use this type alias with functions that return Results that don't use type (). Since Rust has type defaults, abstract CommandResult to accept type T with a default type of () which doesn't compromise the existing usage of CommandResult, but adds onto it. Signed-off-by: kingbri <bdashore3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in Discord, this allows users to provide an optional type to return on success for CommandResult.