Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed all clippy warnings #985

Merged
merged 2 commits into from
Oct 1, 2020
Merged

Fixed all clippy warnings #985

merged 2 commits into from
Oct 1, 2020

Conversation

ikkerens
Copy link
Contributor

@ikkerens ikkerens commented Oct 1, 2020

All of them. No more clippy warnings.
Had to #[allow] a few things, most notably things that would result in breaking API or clippy-compiler disagreements.

Erk-
Erk- reviewed Oct 1, 2020
View reviewed changes
Copy link
Member

@Erk- Erk- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a small nit

src/client/mod.rs Outdated Show resolved Hide resolved
@arqunis arqunis added client Related to the `client` module. enhancement An improvement to Serenity. model Related to the `model` module. cache Related to the `cache`-feature. framework Related to the `framework` and `framework::standard` modules and/or the `command_attr` crate utils Related to the `utils` module. examples Related to Serenity's examples. labels Oct 1, 2020
@arqunis arqunis merged commit ffc2997 into serenity-rs:current Oct 1, 2020
@ikkerens ikkerens deleted the patch-clippy-fixes branch October 1, 2020 17:41
arqunis pushed a commit to arqunis/serenity that referenced this pull request Nov 9, 2020
@ikkerens @arqunis
Fix all clippy warnings and deprecate Client::new (serenity-rs#985)
b8eee4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erk- Erk- Erk- left review comments

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
cache Related to the `cache`-feature. client Related to the `client` module. enhancement An improvement to Serenity. examples Related to Serenity's examples. framework Related to the `framework` and `framework::standard` modules and/or the `command_attr` crate model Related to the `model` module. utils Related to the `utils` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ikkerens @Erk- @arqunis