fix(source): HLS would not work if used directly. #262
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes HlsRequest to return true in
Compose::should_create_async.
This would otherwise cause it to be spawned on a thread without a
executor causing it to panic.
This would only cause issues if used directly since we otherwise use
Compose::create in a context where we have access to the executor.
Closes #257
Open questions:
create
implementation be removed or have a note that it will panic if called outside of a tokio executor?