Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sergei/wall 1837/remove svg badge #5

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Sergei/wall 1837/remove svg badge #5

merged 2 commits into from
Sep 15, 2023

Conversation

sergei-deriv
Copy link
Owner

Changes:

Please include a summary of the change and which issue is fixed below:

  • ...

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@sergei-deriv
Merge remote-tracking branch 'upstream/feature/wallets_with_traders_h…
ec7b832 
…ub_2' into sergei/wall-1837/remove-svg-badge
@sergei-deriv sergei-deriv force-pushed the sergei/wall-1837/remove-svg-badge branch from c78e534 to 8ae94ca Compare September 13, 2023 09:18
@coveralls
Copy link

coveralls commented Sep 13, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6194485601

  • 173 of 253 (68.38%) changed or added relevant lines in 26 files are covered.
  • 15 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.004%) to 10.895%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/src/App/Containers/AccountSwitcherWallet/account-switcher-wallet.tsx 15 16 93.75%
packages/hooks/src/useWalletTransactions.ts 4 5 80.0%
packages/hooks/src/useAvailableWallets.ts 5 8 62.5%
packages/core/src/App/Containers/Layout/header/header.jsx 0 4 0.0%
packages/core/src/App/Components/Layout/Header/wallets/account-info-wallets.tsx 23 28 82.14%
packages/core/src/App/Components/Layout/Header/wallets/accounts-info-loader-wallets.tsx 0 6 0.0%
packages/hooks/src/useFilteredCFDAccounts.ts 25 32 78.13%
packages/core/src/App/Components/Layout/Header/wallets/account-actions-wallets.tsx 0 16 0.0%
packages/core/src/App/Containers/Layout/header/dtrader-header-wallets.tsx 0 37 0.0%
Files with Coverage Reduction New Missed Lines %
packages/core/src/App/Components/Layout/Header/account-info.jsx 1 94.74%
packages/hooks/src/useAvailableWallets.ts 1 71.7%
packages/stores/src/mockStore.ts 1 0.0%
packages/hooks/src/useFilteredCFDAccounts.ts 3 73.21%
packages/hooks/src/useWalletTransactions.ts 4 65.22%
packages/core/src/App/Containers/Layout/header/header.jsx 5 0.0%
Totals Coverage Status
Change from base Build 6169426335: 0.004%
Covered Lines: 11375
Relevant Lines: 89139
💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Sep 13, 2023 •
edited
Loading

⏳ Generating Lighthouse report...

@sergei-deriv sergei-deriv force-pushed the sergei/wall-1837/remove-svg-badge branch from 8ae94ca to cee3d6a Compare September 13, 2023 11:39
@sergei-deriv sergei-deriv force-pushed the sergei/wall-1837/remove-svg-badge branch from cee3d6a to 16b833b Compare September 15, 2023 06:02
@sergei-deriv sergei-deriv merged commit 32fadce into sergei/wall-1248/account-dropdown-dtrader-dbot Sep 15, 2023
2 checks passed
sergei-deriv pushed a commit that referenced this pull request Oct 5, 2023
@kate-deriv @henry-deriv @maryia-deriv
Kate / DTRA-353 /TS migration of trader package 4 (deriv-com#9657)
4e03c04 
* fix: ts-migrate trade-params

* fix: sonarcloud

* fix: pull in changes from tech debt 2 package

* fix: resolve comments

* fix: move type to common prop types

* fix: move type to common prop types

* fix: move type to common prop types file

* fix: resolve comments

* Kate / DTRA-321 / TS migration of trade-params and trade-params-mobile (#6)

* refactor: migrate trade params and started mobile version

* refactor: ts migration of trade params mobile

* chore: add nessasary prop

* refactor: apply suggestions

* chore: change todo text

* refactor: add import

* fix: circleCI error

* fix: ts migrate trade-footer-extensions.jsx

* fix: fix import

* fix: remove progress-slider-stream since its not used

* fix: resolve comments

* fix: reset with master

* fix: reset with master

* fix: reset with master

* fix: reset with master

* fix: circleCI

* fix: togglePositions folder

* fix: dtra-346 marketisclosed and marketcountdowntimer migration

* fix: bug

* Maryia/dtra-270/TS migration: trade-store (#5)

* chore: prepare for migration

* chore: add more types to trade-store

* chore: add more types to trade-store

* chore: add more types to trade-store

* chore: add more types to trade-store

* chore: migrated trade-store to ts

* chore: improve types in trade-store

* fix: type

* revert: hooks package installation

* refactor: address review

* fix: resolve comments

* feat: add ts migartion of store

* refactor: add prev changes

* chore: empty commit

* fix: add lost mocked

* fix: resolve comments

* Kate / DTRA-354 / Components/Form/Purchase files in Trader package (deriv-com#21)

* refactor: ts migartion of purchase files

* refactor: remove duplicated types

* refactor: apply suggestions

* maryia/fix: sonarcloud warnings (#7)

* fix: sonarcloud warnings

* fix: Unexpected end of JSON input

* fix: bug

* fix: sonarcloud

* fix: reorder props

* fix: test cases

* fix: coveralls

* fix: coveralls

* fix: this component doesnt exist anymore, hence test was also removed

* henry/dtra-356/fix: ts-migration-digitsJSX (deriv-com#24)

* fix: initial commit

* fix: ts migrate digits JSX

* fix: small type change

* fix: comment

* chore: removed unused state

* Maryia/dtra-355/Migrate ContractDrawer files to TS (deriv-com#22)

* feat: migrated swipeable-components to TS

* feat: migrated market-closed-contract-overlay & index to TS

* chore: migrated contract-drawer-card.tsx to ts

* build: fix type

* chore: migrated contract-drawer to ts

* chore: fixed existing types in digits and logic

* chore: sort types properties in alphabetical order

* Kate/dtra 357/ts contract audit files (deriv-com#23)

* refactor: apply suggestion from prev pr

* refactor: start ts migration of contract audit

* chore: change comment

* refactor: ts of contract audit item

* refactor: ts migration of contract details

* refactor: ts migration of contract history

* refactor: add preprepared types

* refactor: tests

* chore: apply nit

* refactor: apply suggestions

* refactor: apply suggestions

* chore: fix of sonar cloud

* Maryia/dtra-373/remove localize from ContractCardHeader component (deriv-com#25)

* refactor: remove localize from contract-card-header

* refactor: use Localize component instead of localize helper

* build: install RTL deps in shared package

* fix: sonar cloud codesmells

* fix: build TS errors (deriv-com#32)

* refactor: tests

* fix: more conflicts

* chore: empty commit

* maryia/fix: type issues on package 4 (deriv-com#41)

* fix: type issues

* chore: file change from package 3

* chore: keep small changes from package 3

* chore: removed unnecessary todo comment

* refactor: apply suggestions

* fix: types in tests

* fix: test extention

* fix: wallet file

* fix: add turbos to types

---------

Co-authored-by: Henry Hein <henry@regentmarkets.com>
Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com>
Co-authored-by: henry-deriv <118344354+henry-deriv@users.noreply.github.com>
sergei-deriv pushed a commit that referenced this pull request Oct 12, 2023
@kate-deriv @henry-deriv @maryia-deriv
Kate / DTRA-375 / [Package 5] Tech debt (deriv-com#9809)
ec0f96e 
* fix: ts-migrate trade-params

* fix: sonarcloud

* fix: pull in changes from tech debt 2 package

* fix: resolve comments

* fix: move type to common prop types

* fix: move type to common prop types

* fix: move type to common prop types file

* fix: resolve comments

* Kate / DTRA-321 / TS migration of trade-params and trade-params-mobile (#6)

* refactor: migrate trade params and started mobile version

* refactor: ts migration of trade params mobile

* chore: add nessasary prop

* refactor: apply suggestions

* chore: change todo text

* refactor: add import

* fix: circleCI error

* fix: ts migrate trade-footer-extensions.jsx

* fix: fix import

* fix: remove progress-slider-stream since its not used

* fix: resolve comments

* fix: reset with master

* fix: reset with master

* fix: reset with master

* fix: reset with master

* fix: circleCI

* fix: togglePositions folder

* fix: dtra-346 marketisclosed and marketcountdowntimer migration

* fix: bug

* Maryia/dtra-270/TS migration: trade-store (#5)

* chore: prepare for migration

* chore: add more types to trade-store

* chore: add more types to trade-store

* chore: add more types to trade-store

* chore: add more types to trade-store

* chore: migrated trade-store to ts

* chore: improve types in trade-store

* fix: type

* revert: hooks package installation

* refactor: address review

* fix: resolve comments

* feat: add ts migartion of store

* refactor: add prev changes

* chore: empty commit

* fix: add lost mocked

* fix: resolve comments

* Kate / DTRA-354 / Components/Form/Purchase files in Trader package (deriv-com#21)

* refactor: ts migartion of purchase files

* refactor: remove duplicated types

* refactor: apply suggestions

* maryia/fix: sonarcloud warnings (#7)

* fix: sonarcloud warnings

* fix: Unexpected end of JSON input

* fix: bug

* fix: sonarcloud

* fix: reorder props

* fix: test cases

* fix: coveralls

* fix: coveralls

* fix: this component doesnt exist anymore, hence test was also removed

* henry/dtra-356/fix: ts-migration-digitsJSX (deriv-com#24)

* fix: initial commit

* fix: ts migrate digits JSX

* fix: small type change

* fix: comment

* chore: removed unused state

* Maryia/dtra-355/Migrate ContractDrawer files to TS (deriv-com#22)

* feat: migrated swipeable-components to TS

* feat: migrated market-closed-contract-overlay & index to TS

* chore: migrated contract-drawer-card.tsx to ts

* build: fix type

* chore: migrated contract-drawer to ts

* chore: fixed existing types in digits and logic

* chore: sort types properties in alphabetical order

* Kate/dtra 357/ts contract audit files (deriv-com#23)

* refactor: apply suggestion from prev pr

* refactor: start ts migration of contract audit

* chore: change comment

* refactor: ts of contract audit item

* refactor: ts migration of contract details

* refactor: ts migration of contract history

* refactor: add preprepared types

* refactor: tests

* chore: apply nit

* refactor: apply suggestions

* refactor: apply suggestions

* chore: fix of sonar cloud

* Maryia/dtra-373/remove localize from ContractCardHeader component (deriv-com#25)

* refactor: remove localize from contract-card-header

* refactor: use Localize component instead of localize helper

* build: install RTL deps in shared package

* feat: merge previous tech debt branch

* fix: sonar cloud codesmells

* Merge branch kate/ts_migration_trader_package_4 into kate/ts_migration_trader_package_5

* Kate / DTRA-378 / TS migration: Multiplier components and containers in Trader package (deriv-com#26)

* refactor: ts of cancel deal and risk managment info

* fix: types in dialog tsx

* refactor: start ts of multiplier options

* refactor: ts of mult amount modal

* refactor: remove default val from basis component

* fix: type of amount mobile

* refactor: applied suggestions

* refactor: ts of multiplier info (deriv-com#28)

* Henry/dtra 376/fix: ts migration positionsdrawer folder (deriv-com#27)

* fix: positions drawer folder

* fix: coveralls

* fix: where is my commit

* fix: found commits

* fix: file rename

* fix: comments

* fix: comments

* fix: correct logic

* fix: remove unused props

* fix: types

* refactor: remove code mells

* fix: ts-migrate-populate header (deriv-com#30)

* Maryia/DTRA-377/TS migration: TradingDatePicker + TradingTimePicker + TimePicker + Dialog (deriv-com#29)

* chore: timepicker to ts

* chore: trading timepicker to ts

* chore: add types for TradingDatePicker & DatePicker

* refactor: added default values

* refactor: remove code small

* chore: empty commit

* fix: not using index as key (deriv-com#31)

* fix: ternary bug

* fix: build TS errors (deriv-com#32)

* refactor: apply suggestions

* refactor: change type of time

* chore: empty commit

* refactor: tests

* fix: conflicts

* fix: conflicts

* fix: tests

* fix: types in tests

* fix: test extention

* fix: add turbos to types back

* fix: add backup for target name

* fix: revert empty strings

---------

Co-authored-by: Henry Hein <henry@regentmarkets.com>
Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com>
Co-authored-by: henry-deriv <118344354+henry-deriv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergei-deriv @coveralls