Skip to content

Commit

Permalink
interop-testing: Start mgmt server before xds server
Browse files Browse the repository at this point in the history
The xds server can take a really long time to start if the xds resources
are slow to load. Ideally the management server would be available
during this time so we can inspect the server. The server health still
won't go to SERVING until the xds server starts, which is appropriate.
  • Loading branch information
ejona86 committed Nov 17, 2023
1 parent 13facb6 commit 514273d
Showing 1 changed file with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -176,14 +176,6 @@ private void start() throws Exception {
}
health = new HealthStatusManager();
if (secureMode) {
server =
XdsServerBuilder.forPort(
port, XdsServerCredentials.create(InsecureServerCredentials.create()))
.addService(
ServerInterceptors.intercept(
new TestServiceImpl(serverId, host), new TestInfoInterceptor(host)))
.build();
server.start();
maintenanceServer =
NettyServerBuilder.forPort(maintenancePort)
.addService(new XdsUpdateHealthServiceImpl(health))
Expand All @@ -192,6 +184,14 @@ private void start() throws Exception {
.addServices(AdminInterface.getStandardServices())
.build();
maintenanceServer.start();
server =
XdsServerBuilder.forPort(
port, XdsServerCredentials.create(InsecureServerCredentials.create()))
.addService(
ServerInterceptors.intercept(
new TestServiceImpl(serverId, host), new TestInfoInterceptor(host)))
.build();
server.start();
} else {
server =
NettyServerBuilder.forPort(port)
Expand Down

0 comments on commit 514273d

Please sign in to comment.