Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Buffer.from() instead of new Buffer(); require node >= 5.10.0. #4

Merged
merged 2 commits into from
Oct 21, 2019

Conversation

millette
Copy link
Collaborator

No description provided.

@millette
Copy link
Collaborator Author

Weird failure on travis about yarn on event-stream dep:

An unexpected error occurred: "http://localhost:4873/event-stream/-/event-stream-3.3.4.tgz: connect ECONNREFUSED 127.0.0.1:4873".

Same in #5.

@millette
Copy link
Collaborator Author

millette commented Oct 20, 2019

Seeing travis tests on node >= 8, perhaps I should change the node engine requirement to 8 also. I just went with the lower version to accomodate Buffer.from(string).

UPDATE: Oh my, I just noticed my yarn.lock and package-lock.json (in all my recent projects) have this localhost:4873 problem, maybe due to verdaccio.

UPDATE 2: According to this it should work with npm but for yarn, we'll have to wait for v2 to solve it. I had switched back to npm from yarn a few months ago, never noticed the issue before.

UPDATE 3: I updated the lock files by bypassing verdaccio.

@sergioramos sergioramos merged commit 99701c2 into sergioramos:master Oct 21, 2019
@sergioramos
Copy link
Owner

this is great, thank you 🙏

@sergioramos
Copy link
Owner

also, added you as collaborator and will publish a major upgrade (might be a breaking change)

@millette
Copy link
Collaborator Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants