eliminated gflags related linker warnings (google#569)

sergiud · Apr 9, 2021 · d65e672 · d65e672
1 parent 663bb26
commit d65e672
Showing 1 changed file with 13 additions and 1 deletion.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -584,7 +584,19 @@ if (gflags_FOUND)
 
   if (NOT BUILD_SHARED_LIBS)
     # Don't use __declspec(dllexport|dllimport) if this is a static build
-    targeT_compile_definitions (glog PUBLIC GFLAGS_DLL_DECLARE_FLAG= GFLAGS_DLL_DEFINE_FLAG=)
+    target_compile_definitions (glog
+      PRIVATE GFLAGS_DLL_DECLARE_FLAG
+      PRIVATE GFLAGS_DLL_DEFINE_FLAG
+      PUBLIC "$<BUILD_INTERFACE:GFLAGS_DLL_DECLARE_FLAG=>"
+      PUBLIC "$<BUILD_INTERFACE:GFLAGS_DLL_DEFINE_FLAG=>"
+    )
+  else (NOT BUILD_SHARED_LIBS)
+    target_compile_definitions (glog
+      PRIVATE GFLAGS_DLL_DECLARE_FLAG=GOOGLE_GLOG_DLL_DECL
+      PRIVATE GFLAGS_DLL_DEFINE_FLAG=GOOGLE_GLOG_DLL_DECL
+      PUBLIC "$<BUILD_INTERFACE:GFLAGS_DLL_DECLARE_FLAG=GOOGLE_GLOG_DLL_DECL>"
+      PUBLIC "$<BUILD_INTERFACE:GFLAGS_DLL_DEFINE_FLAG=GOOGLE_GLOG_DLL_DECL>"
+    )
   endif (NOT BUILD_SHARED_LIBS)
 endif (gflags_FOUND)