Fix encoding for stream _write #2643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gareth Hancock <64541249+GazHank@users.noreply.github.com>
reconbot
approved these changes
Jun 28, 2023
|
Hmm, do we need to look at changing the _writev function too? node-serialport/packages/stream/lib/index.ts Line 275 in 0585e64 |
|
I'm suspect that this is the correct type as nodejs used to pass undefined there all the time. Curious how that's been upgraded for older libraries and packages. Whatever type changes make us look like a stream are fine by me. |
3 tasks
|
Any news on this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix per #2566
This matches the definition of _write definition for Duplex streams
Signed-off-by: Gareth Hancock 64541249+GazHank@users.noreply.github.com