Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple delimiters in PacketLengthParser, as well as delimiters of sizes > 1 byte #2709

Closed
wants to merge 3 commits into from

Conversation

bbeck13
Copy link

@bbeck13 bbeck13 commented Sep 23, 2023

I've used this for a situation where the delimiter can be many different things each specific delimiter denotes a type of packet, and because there are so many it has to be multiple bytes. This doesn't break any existing functionality and consumers do not need to use this if they stick with the defaults.

I've updated the documentation for this here
serialport/website#125

@bbeck13
Copy link
Author

bbeck13 commented Sep 24, 2023

#2679

So there's at least one other person who wants this.

@zellb
Copy link

zellb commented Jan 12, 2024

Is there any chance this will get merged?

@bbeck13
Copy link
Author

bbeck13 commented Jan 26, 2024

Is there any chance this will get merged?

I wish I'm not sure who to @ to move this along

I ended up building my branch into the projects I'm using this for feel free to do the same, kind of annoying bc it doesn't publish anywhere but not the end of the world

@bbeck13
Copy link
Author

bbeck13 commented Apr 9, 2024

1712688708117828

@reconbot
Copy link
Member

reconbot commented Dec 24, 2024

This isn't my full time job or my family, I'm able to maintain serialport the best I can.

The feature however is great, glad to have it. I can't merge this as is because of the version bump and merge with master, however I can cherrypick your commit with the new feature in a new branch, your name will still be on the commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants