This repository has been archived by the owner on Jun 1, 2024. It is now read-only.
Added FormatStackTraceAsArray option to write StackTrace as an array #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Would it be possible to add a unit test for this? And can you also list this option in the readme.md to explain to users why you want this option? |
added 2 commits
April 6, 2019 11:24
…sticsearch into format-stacktrace-as-array
|
@mivano, I added two unit tests. Also, I changed the Configure the Sink wiki page, explaining the use of the flag. The README.md doesn't seem to have any content related to the Sink Options. |
|
Nice, thanks. I merged it into dev, so beta packages should be available soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this PR address?
This PR fixes #229
Does this PR introduce a breaking change?
No. The new flag is false by default, which keeps the current behavior. If the flag is set to true the new behavior takes place.
Please check if the PR fulfills these requirements
Other information: