Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

Add Enrich.WithXXX() extension methods for each enricher so that it can be used in settings providers #8

Closed
tsimbalar opened this issue May 23, 2018 · 0 comments
Closed

Add Enrich.WithXXX() extension methods for each enricher so that it can be used in settings providers #8

tsimbalar opened this issue May 23, 2018 · 0 comments
Labels
enhancement good first issue up-for-grabs

Comments

@tsimbalar
Copy link
Member

Right now, the Enrichers declared in SerilogWeb.Classic.Mvc cannot be used with Serilog.Settings.AppSettings because no extension method is available, and calls to generic methods (Enrich.With<Enricher>()) are not supported in Serilog.Settings.AppSettings.

It is a similar issue than the one solved in serilog-web/classic#53 and serilog-web/webapi#14
@tsimbalar tsimbalar mentioned this issue May 24, 2018
Merged
@dgarciarubio dgarciarubio mentioned this issue May 28, 2018
Merged
tsimbalar added a commit that referenced this issue May 29, 2018
@tsimbalar
Merge pull request #10 from dgarciarubio/app-settings
8640321 
App settings support by adding specific extension methods

solves #8
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement good first issue up-for-grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tsimbalar