Merge pull request #432 from 0xced/string-to-enum-ignore-case

Make string to enum conversion case insensitive
serilog · Aug 6, 2024 · 296a8ba · 296a8ba
2 parents e42be6a + 47f447a
commit 296a8ba
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/Serilog.Settings.Configuration/Settings/Configuration/StringArgumentValue.cs b/src/Serilog.Settings.Configuration/Settings/Configuration/StringArgumentValue.cs
@@ -51,7 +51,7 @@ public StringArgumentValue(string providedValue)
         }
 
         if (toTypeInfo.IsEnum)
-            return Enum.Parse(toType, argumentValue);
+            return Enum.Parse(toType, argumentValue, ignoreCase: true);
 
         var convertor = ExtendedTypeConversions
             .Where(t => t.Key.GetTypeInfo().IsAssignableFrom(toTypeInfo))

diff --git a/test/Serilog.Settings.Configuration.Tests/StringArgumentValueTests.cs b/test/Serilog.Settings.Configuration.Tests/StringArgumentValueTests.cs
@@ -222,10 +222,12 @@ public void ReferencingUndeclaredLevelSwitchThrows()
         Assert.Contains("\"LevelSwitches\":{\"$mySwitch\":", ex.Message);
     }
 
-    [Fact]
-    public void StringValuesConvertToEnumByName()
+    [Theory]
+    [InlineData("Information")]
+    [InlineData("information")]
+    public void StringValuesConvertToEnumByName(string level)
     {
-        var value = new StringArgumentValue(nameof(LogEventLevel.Information));
+        var value = new StringArgumentValue(level);
 
         var actual = value.ConvertTo(typeof(LogEventLevel), new());