perf: warn the usage of RENOVATE_GIT_AUTHOR #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msclock
force-pushed
the
opt_renovate_job
branch
from
5d573f0
to
9166ebf
Compare
|
On Gitlab, it seems there is no needs to warn. It essentially equals the second impact on GitHub. |
huxuan
reviewed
Apr 16, 2024
Signed-off-by: msclock <msclock@qq.com>
Signed-off-by: msclock <msclock@qq.com>
msclock
force-pushed
the
opt_renovate_job
branch
3 times, most recently
from
2db61d0
to
cdc5f3f
Compare
Signed-off-by: msclock <msclock@qq.com>
msclock
force-pushed
the
opt_renovate_job
branch
from
cdc5f3f
to
a075673
Compare
huxuan
reviewed
Apr 22, 2024
There was a problem hiding this comment.
The changes to workflow looks good to me. Just some expression change with the help of ChatGPT. :-)
Let us remove the changes to documentation currently, I am not mean we have to add documentation before merge this pull request. Maybe we need a more comprehensive plan to update the documentation.
Signed-off-by: msclock <msclock@qq.com>
msclock
force-pushed
the
opt_renovate_job
branch
2 times, most recently
from
1b0080d
to
54b7597
Compare
msclock
force-pushed
the
opt_renovate_job
branch
2 times, most recently
from
37c2dc6
to
82696c8
Compare
huxuan
approved these changes
Apr 23, 2024
|
Thanks! |
|
🎉 This PR is included in version 0.0.51 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have checked and decide to warn user's usage of RENOVATE_GIT_AUTHOR when enable a app bot.
The changes have impacts:
Related #400
Related #436