e2e: adjust tests

serlo · Nov 21, 2024 · 6421150 · 6421150
1 parent 6c2fd3e
commit 6421150
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 12 deletions.
diff --git a/e2e-tests/tests/430-multimedia-plugin.ts b/e2e-tests/tests/430-multimedia-plugin.ts
@@ -43,7 +43,7 @@ Scenario('Multimedia plugin toolbar controls', async ({ I }) => {
     'aria-selected': 'true',
   })
   I.click('$modal-close-button')
-  I.seeElement('.media-wrapper.mobile\\:w-1\\/4')
+  I.seeElement('.media-wrapper.mobile\\:basis-1\\/4')
 
   I.say('Change the type of the multimedia content to video')
   I.click('$plugin-multimedia-settings-button')

diff --git a/e2e-tests/tests/480-focus.ts b/e2e-tests/tests/480-focus.ts
@@ -68,24 +68,18 @@ Scenario('focus plugins with tab key', async ({ I }) => {
   createNewEditorEntity(I, 'article')
   I.waitForElement('h1 > input:focus', 5)
 
-  I.say('focus on image plugin inside of introduction multimedia plugin')
-  // TODO: Double tab is a quick fix, focus / toolbar visibility needs to be improved in image ,
-  //       specifically with ImageSelectionScreen component
+  I.say('focus on text plugin inside of introduction multimedia plugin')
   I.pressKey('Tab')
+  I.see('Text', '$plugin-type-indicator')
+
+  I.say('focus on image plugin inside of introduction multimedia plugin')
   I.pressKey('Tab')
   I.see('Bild', '$plugin-type-indicator')
   I.see('Erklärung mit Multimedia-Inhalt', '$plugin-multimedia-parent-button')
 
-  I.say('focus on text plugin inside of introduction multimedia plugin')
-  // TODO: Triple tab is a quick fix, its not clear that the tab order is correct for a good UX
-  I.pressKey('Tab')
+  I.say('focus on text plugin under introduction multimedia plugin')
   I.pressKey('Tab')
   I.pressKey('Tab')
-
-  I.see('Text', '$plugin-type-indicator')
-  I.see('Erklärung mit Multimedia-Inhalt', '$plugin-multimedia-parent-button')
-
-  I.say('focus on text plugin under introduction multimedia plugin')
   I.pressKey('Tab')
   I.pressKey('Tab')
   I.see('Text', '$plugin-type-indicator')