Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): use EditorImage on subject landing pages #4247

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

elbotho
Copy link
Member

@elbotho elbotho commented Nov 4, 2024

No description provided.

Copy link

vercel bot commented Nov 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend 🔄 Building (Inspect) Visit Preview Nov 4, 2024 4:49pm

@elbotho elbotho merged commit 125c889 into staging Nov 4, 2024
8 checks passed
@elbotho elbotho deleted the fix/serlo-asset-proxy branch November 4, 2024 16:49
@github-actions github-actions bot mentioned this pull request Nov 4, 2024
Copy link
Contributor

github-actions bot commented Nov 4, 2024

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Sixty-nine Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 86.25 KB (🟡 +47 B) 190.67 KB
/404 42.9 KB (🟡 +47 B) 147.32 KB
/500 42.9 KB (🟡 +47 B) 147.32 KB
/[...slug] 87.14 KB (🟡 +19 B) 191.56 KB
/___bot_or_not 101.88 KB (🟡 +19 B) 206.3 KB
/___cf_not_found 41.12 KB (🟡 +47 B) 145.53 KB
/___design 146.41 KB (🟡 +47 B) 250.83 KB
/___editor_preview 530.22 KB (🟡 +19 B) 634.64 KB
/___old_comments 103.33 KB (🟡 +47 B) 207.75 KB
/auth/___activate_vidis 41.41 KB (🟡 +47 B) 145.83 KB
/auth/error 66.71 KB (🟡 +47 B) 171.13 KB
/auth/login 94.42 KB (🟡 +47 B) 198.84 KB
/auth/logout 85.14 KB (🟡 +47 B) 189.56 KB
/auth/oauth/consent 58.98 KB (🟡 +47 B) 163.4 KB
/auth/oauth/login 94.43 KB (🟡 +47 B) 198.85 KB
/auth/oauth/logout 85.15 KB (🟡 +47 B) 189.57 KB
/auth/recovery 76.08 KB (🟡 +47 B) 180.5 KB
/auth/registration 76.84 KB (🟡 +47 B) 181.26 KB
/auth/settings 76.96 KB (🟡 +47 B) 181.38 KB
/auth/verification 76.24 KB (🟡 +47 B) 180.65 KB
/authorization/roles 70.84 KB (🟡 +47 B) 175.26 KB
/backend 43.17 KB (🟡 +47 B) 147.59 KB
/biologie 155.7 KB (🟡 +25 B) 260.12 KB
/chemie 155.7 KB (🟡 +25 B) 260.12 KB
/consent 41.71 KB (🟡 +47 B) 146.13 KB
/content-only/[...slug] 79.18 KB (🟡 +19 B) 183.6 KB
/discussions 99.88 KB (🟡 +47 B) 204.3 KB
/editor 79.95 KB (🟡 +19 B) 184.37 KB
/entity/create/[type]/[taxonomyId] 550.31 KB (🟡 +19 B) 654.72 KB
/entity/license/update/[id] 61 KB (🟡 +47 B) 165.42 KB
/entity/repository/add-revision/[...id] 550.04 KB (🟡 +19 B) 654.46 KB
/entity/repository/compare/[entity_id]/[revision_id] 91.88 KB (🟡 +19 B) 196.3 KB
/entity/repository/history/[id] 73.93 KB (🟡 +47 B) 178.35 KB
/entity/taxonomy/update/[id] 73.49 KB (🟡 +47 B) 177.9 KB
/entity/unrevised 47.95 KB (🟡 +47 B) 152.37 KB
/event/history 127.09 KB (🟡 +47 B) 231.51 KB
/event/history/[...slug] 128.06 KB (🟡 +47 B) 232.48 KB
/event/history/user/profile/[username] 130.45 KB (🟡 +47 B) 234.87 KB
/gleichungs-app 165.21 KB (🟡 +47 B) 269.63 KB
/informatik 155.7 KB (🟡 +25 B) 260.12 KB
/jobs/[[...jobId]] 52.39 KB (🟡 +47 B) 156.81 KB
/legal 41.18 KB (🟡 +47 B) 145.59 KB
/lerntipps 155.7 KB (🟡 +25 B) 260.12 KB
/license/detail/[id] 67.09 KB (🟡 +19 B) 171.51 KB
/mathe 155.7 KB (🟡 +25 B) 260.12 KB
/mathe-aufgaben 41.92 KB (🟡 +47 B) 146.34 KB
/mathe-pruefungen/[region] 78.28 KB (🟡 +47 B) 182.7 KB
/metadata 50.85 KB (🟡 +47 B) 155.27 KB
/nachhaltigkeit 155.7 KB (🟡 +25 B) 260.12 KB
/page/create 550.03 KB (🟡 +19 B) 654.45 KB
/pages 62.31 KB (🟡 +47 B) 166.73 KB
/privacy 44.85 KB (🟡 +47 B) 149.26 KB
/search 43.2 KB (🟡 +47 B) 147.61 KB
/spenden 55.59 KB (🟡 +47 B) 160.01 KB
/subscriptions/manage 110.18 KB (🟡 +47 B) 214.6 KB
/taxonomy/term/[copyOrMove]/batch/[id] 87.46 KB (🟡 +47 B) 191.87 KB
/taxonomy/term/create/[parent_id]/[id] 549.78 KB (🟡 +19 B) 654.2 KB
/taxonomy/term/sort/entities/[id] 97.85 KB (🟡 +47 B) 202.27 KB
/taxonomy/term/update/[id] 549.73 KB (🟡 +19 B) 654.14 KB
/team 48.96 KB (🟡 +47 B) 153.38 KB
/terms 41.2 KB (🟡 +47 B) 145.62 KB
/user/[...userslug] 41 KB (🟡 +47 B) 145.42 KB
/user/me 40.99 KB (🟡 +47 B) 145.41 KB
/user/notifications 129.42 KB (🟡 +47 B) 233.83 KB
/user/profile/[username] 178.66 KB (🟡 +19 B) 283.08 KB
/user/settings 551.72 KB (🟡 +19 B) 656.14 KB
/uuid/recycle-bin 84.56 KB (🟡 +47 B) 188.97 KB
/wallet 43.9 KB (🟡 +47 B) 148.32 KB
/willkommen 88.14 KB (🟡 +47 B) 192.56 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant