Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade Slate #4308

Merged
merged 2 commits into from
Nov 21, 2024
Merged

chore: upgrade Slate #4308

merged 2 commits into from
Nov 21, 2024

Conversation

hejtful
Copy link
Contributor

@hejtful hejtful commented Nov 21, 2024

  • Upgrade @prezly/slate-lists, slate and slate-react
  • Add slate-dom to dependencies to fix an error
  • Remove @types/slate-react as it was unnecessary
  • Add @types/is-hotkey as it became necessary 🤷
  • Make Slate-related versions fixed in package.json
  • +
  • Fix failing e2e tests on staging

Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Nov 21, 2024 10:53am

Copy link
Contributor

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 104.87 KB (🟢 -15 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/___editor_preview 629.43 KB (🟢 -485 B) 734.3 KB
/editor 79.4 KB (-3 B) 184.28 KB
/entity/create/[type]/[taxonomyId] 649.7 KB (🟢 -487 B) 754.57 KB
/entity/repository/add-revision/[...id] 649.44 KB (🟢 -486 B) 754.31 KB
/page/create 649.42 KB (🟢 -487 B) 754.29 KB
/taxonomy/term/create/[parent_id]/[id] 649.17 KB (🟢 -486 B) 754.04 KB
/taxonomy/term/update/[id] 649.12 KB (🟢 -485 B) 753.99 KB
/user/settings 651.09 KB (🟢 -485 B) 755.96 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link
Contributor

@CodingDive CodingDive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great on my end! Thank you ❤️
Just curious, were these the fuzzy tests before, or did they break as part of the upgrade?

@hejtful
Copy link
Contributor Author

hejtful commented Nov 21, 2024

They're from the focus/hover redesign, I just noticed them on staging after merging 😁

Copy link
Member

@LarsTheGlidingSquirrel LarsTheGlidingSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Tested the text plugin a bit and found no issue regarding the slate upgrade.

@hejtful hejtful merged commit 0c473ec into staging Nov 21, 2024
9 checks passed
@hejtful hejtful deleted the chore/upgrade-slate branch November 21, 2024 16:26
@github-actions github-actions bot mentioned this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants