Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support to wikimedia videos due to data privacy reasons #4312

Merged
merged 6 commits into from
Dec 2, 2024

Conversation

hugotiburtino
Copy link
Member

@hugotiburtino hugotiburtino commented Nov 22, 2024

Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Nov 22, 2024 0:33am

Copy link
Contributor

github-actions bot commented Nov 22, 2024

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Twenty-three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/[...slug] 86.6 KB (🟡 +8 B) 191.48 KB
/___bot_or_not 98.09 KB (🟡 +8 B) 202.96 KB
/___editor_preview 629.43 KB (-12 B) 734.3 KB
/biologie 155.22 KB (🟡 +8 B) 260.1 KB
/chemie 155.22 KB (🟡 +8 B) 260.1 KB
/consent 41.02 KB (🟢 -19 B) 145.89 KB
/content-only/[...slug] 78.68 KB (🟡 +8 B) 183.56 KB
/editor 79.41 KB (🟡 +8 B) 184.29 KB
/entity/create/[type]/[taxonomyId] 649.7 KB (-12 B) 754.57 KB
/entity/repository/add-revision/[...id] 649.44 KB (-12 B) 754.31 KB
/entity/repository/compare/[entity_id]/[revision_id] 91.26 KB (🟡 +8 B) 196.13 KB
/informatik 155.23 KB (🟡 +8 B) 260.1 KB
/lerntipps 155.22 KB (🟡 +8 B) 260.1 KB
/license/detail/[id] 66.58 KB (🟡 +8 B) 171.46 KB
/mathe 155.22 KB (🟡 +8 B) 260.09 KB
/nachhaltigkeit 155.23 KB (🟡 +8 B) 260.1 KB
/page/create 649.42 KB (-12 B) 754.29 KB
/search 42.5 KB (🟢 -19 B) 147.38 KB
/spenden 54.84 KB (🟢 -14 B) 159.71 KB
/taxonomy/term/create/[parent_id]/[id] 649.17 KB (-12 B) 754.04 KB
/taxonomy/term/update/[id] 649.12 KB (-12 B) 753.99 KB
/user/profile/[username] 174.27 KB (🟡 +8 B) 279.14 KB
/user/settings 651.09 KB (-12 B) 755.96 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link
Member

@elbotho elbotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you.

Follow ups (not urgent at all):

  • remove from consent (frontend)
  • remove from preview (cf-worker)

(preview build fail should be a temporary problem, no blocker)

@hugotiburtino
Copy link
Member Author

Sorry, I've noticed a minor bug. I'll make it a draft and let you know when it is ok again

@hugotiburtino hugotiburtino marked this pull request as draft November 22, 2024 11:13
@hugotiburtino
Copy link
Member Author

Now, it shows the video preview directly (No message "Video abspielen von....").

You can test at https://frontend-git-remove-wikimedia-video-serlo.vercel.app/___editor_preview with
https://storage.googleapis.com/assets.serlo.org/wikimedia/Mfnf-linear-skalar2.webm

@hugotiburtino hugotiburtino marked this pull request as ready for review November 22, 2024 12:35
@hugotiburtino hugotiburtino changed the title Remove support to wikimedia videos for data privacy reasons Remove support to wikimedia videos due to data privacy reasons Nov 22, 2024
Copy link
Member

@elbotho elbotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
This could in theory affect other editor integrations, but since it's so seldomly used I think the risk is small enough.

@elbotho elbotho merged commit f5dd39e into staging Dec 2, 2024
9 checks passed
@elbotho elbotho deleted the remove-wikimedia-video branch December 2, 2024 11:00
@github-actions github-actions bot mentioned this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants