fix(plugin-edusharing): use open-iframe-resizer #4314
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle Analysis for @serlo/frontendThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! One Page Changed SizeThe following page changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
There was a problem hiding this comment.
Looks good!
For the follow-up, I changed the plugin-injection to open-iframe-resizer in this PR, and it looks good! Although I'm not very familiar with plugin-injection, so I might have missed something.
Please feel free to merge the PR and also remove iframe-resizer from editor dependencies. Or we can also just merge this PR and wait for Botho to approve the plugin-injection change. Your call :)
…ame-resizer refactor(plugin-injection): use open-iframe-resizer
|
@hejtful your PR changes |
| @@ -52,7 +52,10 @@ export default renderedPageNoHooks<SlugProps>(({ pageData }) => { | |||
| serloEntityData={{ entityId }} | |||
| authorization={pageData.authorization} | |||
| > | |||
| <LazyIframeResizer /> | |||
| <Script | |||
| src="https://cdn.jsdelivr.net/npm/@open-iframe-resizer/core@1.2.1/dist/index.min.js" | |||
There was a problem hiding this comment.
could we host this on serlo.org to avoid any privacy concerns?
There was a problem hiding this comment.
I think so. Just have not done it yet.
LarsTheGlidingSquirrel
deleted the
plugin-edusharing-use-open-iframe-resizer
branch
No description provided.