Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(web): hide localstorage notice on editor-preview as well #4325

Conversation

elbotho
Copy link
Member

@elbotho elbotho commented Nov 29, 2024

small suggestion

Copy link

vercel bot commented Nov 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Nov 29, 2024 9:04am

Copy link
Contributor

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 104.86 KB (-2 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Seven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/___editor_preview 630.46 KB (🟡 +4 B) 735.32 KB
/entity/create/[type]/[taxonomyId] 650.73 KB (🟡 +4 B) 755.59 KB
/entity/repository/add-revision/[...id] 650.47 KB (🟡 +4 B) 755.33 KB
/page/create 650.45 KB (🟡 +4 B) 755.31 KB
/taxonomy/term/create/[parent_id]/[id] 650.2 KB (🟡 +4 B) 755.06 KB
/taxonomy/term/update/[id] 650.15 KB (🟡 +4 B) 755.01 KB
/user/settings 652.12 KB (🟡 +4 B) 756.98 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link
Member

@LarsTheGlidingSquirrel LarsTheGlidingSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better! Thank you! 💚

@LarsTheGlidingSquirrel LarsTheGlidingSquirrel merged commit 3006f43 into fix-remove-editor-toolbar-in-editor-preview Nov 29, 2024
9 checks passed
@LarsTheGlidingSquirrel LarsTheGlidingSquirrel deleted the small-change-editor-preview branch November 29, 2024 13:49
@github-actions github-actions bot mentioned this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants