Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Render visual/latex select in math toolbar #4334

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

CodingDive
Copy link
Contributor

@CodingDive CodingDive commented Dec 3, 2024

Before
image

After
image

@CodingDive CodingDive requested a review from elbotho December 3, 2024 17:34
Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Dec 3, 2024 5:53pm

Copy link
Contributor

github-actions bot commented Dec 3, 2024

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Seven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/___editor_preview 637.53 KB (🟡 +8 B) 742.4 KB
/entity/create/[type]/[taxonomyId] 657.81 KB (🟡 +8 B) 762.68 KB
/entity/repository/add-revision/[...id] 657.55 KB (🟡 +8 B) 762.42 KB
/page/create 657.53 KB (🟡 +8 B) 762.4 KB
/taxonomy/term/create/[parent_id]/[id] 657.28 KB (🟡 +8 B) 762.15 KB
/taxonomy/term/update/[id] 657.23 KB (🟡 +8 B) 762.1 KB
/user/settings 659.2 KB (🟡 +8 B) 764.07 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@CodingDive CodingDive marked this pull request as ready for review December 3, 2024 17:37
Copy link
Member

@elbotho elbotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@CodingDive CodingDive merged commit 52d8aab into staging Dec 3, 2024
9 checks passed
@CodingDive CodingDive deleted the fix/portal-math-toolbar-controls branch December 3, 2024 18:16
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants