Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-video): allow video upload via new infra #4368

Draft
wants to merge 8 commits into
base: staging
Choose a base branch
from

Conversation

elbotho
Copy link
Member

@elbotho elbotho commented Dec 19, 2024

do not merge before new asset infra is used

TODO:

  • investigate bundle size increase!
  • adapt e2e tests
  • sanity check backend, file sizes, file types etc
  • should we use a player lib or is native video good enough for now?
  • test with interactive video

@hejtful this is unfortunately blocked by us not using the new media infra in production yet, but maybe you can already review it. Should work fine in local/staging.

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Dec 20, 2024 4:14pm

Copy link
Contributor

github-actions bot commented Dec 19, 2024

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Twenty-one Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/[...slug] 94.78 KB (🟡 +46 B) 199.65 KB
/___bot_or_not 106.23 KB (🟡 +46 B) 211.11 KB
/___editor_preview 664.56 KB (🟡 +994 B) 769.43 KB
/biologie 163.46 KB (🟡 +46 B) 268.33 KB
/chemie 163.46 KB (🟡 +46 B) 268.33 KB
/content-only/[...slug] 86.88 KB (🟡 +46 B) 191.75 KB
/editor 87.69 KB (🟡 +46 B) 192.56 KB
/entity/create/[type]/[taxonomyId] 684.84 KB (🟡 +992 B) 789.72 KB
/entity/repository/add-revision/[...id] 684.58 KB (🟡 +993 B) 789.45 KB
/entity/repository/compare/[entity_id]/[revision_id] 99.43 KB (🟡 +46 B) 204.31 KB
/informatik 163.46 KB (🟡 +46 B) 268.33 KB
/lerntipps 163.46 KB (🟡 +46 B) 268.33 KB
/license/detail/[id] 74.73 KB (🟡 +46 B) 179.61 KB
/mathe 163.46 KB (🟡 +46 B) 268.33 KB
/nachhaltigkeit 163.46 KB (🟡 +46 B) 268.34 KB
/page/create 684.56 KB (🟡 +992 B) 789.43 KB
/taxonomy/term/[copyOrMove]/batch/[id] 84.38 KB (🟡 +162 B) 189.25 KB
/taxonomy/term/create/[parent_id]/[id] 684.31 KB (🟡 +992 B) 789.18 KB
/taxonomy/term/update/[id] 684.26 KB (🟡 +992 B) 789.13 KB
/user/profile/[username] 182.52 KB (🟡 +46 B) 287.39 KB
/user/settings 686.23 KB (🟡 +993 B) 791.1 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Base automatically changed from fix/bug-pasting-images to staging December 20, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant