Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translation: flowcontrol plugin #1486

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

daizhenyu
Copy link
Collaborator

@daizhenyu daizhenyu commented Apr 7, 2024

What type of PR is this?

Doc

What this PR does / why we need it?

This initiative aims to enhance readability, accessibility, and collaboration for both current and potential contributors, ensuring a unified language throughout the codebase.

Which issue(s) this PR fixes?

Fixes #1466

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

@daizhenyu daizhenyu force-pushed the translate-flowcontrol branch from 3b55b21 to c306e1f Compare April 8, 2024 11:05
@daizhenyu daizhenyu force-pushed the translate-flowcontrol branch 3 times, most recently from 1ea77cc to 9ba1d57 Compare April 9, 2024 07:40
Signed-off-by: daizhenyu <1449308021@qq.com>
@daizhenyu daizhenyu force-pushed the translate-flowcontrol branch from 9ba1d57 to 4e1796d Compare April 9, 2024 11:32
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 43.58%. Comparing base (36a016b) to head (4e1796d).
Report is 5 commits behind head on develop.

Files Patch % Lines
...control/common/core/resolver/AbstractResolver.java 0.00% 4 Missing ⚠️
...wcontrol/retry/AlibabaDubboInvokerInterceptor.java 50.00% 3 Missing ⚠️
...wei/flowcontrol/retry/ExtentionLoaderDeclarer.java 0.00% 3 Missing ⚠️
...ol/common/core/rule/RuleDynamicConfigListener.java 0.00% 2 Missing ⚠️
...n/java/com/huawei/flowcontrol/ClusterDeclarer.java 0.00% 2 Missing ⚠️
.../flowcontrol/retry/cluster/ApacheDubboCluster.java 0.00% 2 Missing ⚠️
...uawei/flowcontrol/common/core/ResolverManager.java 50.00% 1 Missing ⚠️
...ol/common/core/match/operator/CompareOperator.java 0.00% 1 Missing ⚠️
...m/huawei/flowcontrol/common/util/ConvertUtils.java 50.00% 0 Missing and 1 partial ⚠️
.../huawei/flowcontrol/DispatcherServletDeclarer.java 0.00% 1 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1486   +/-   ##
==========================================
  Coverage      43.58%   43.58%           
  Complexity       181      181           
==========================================
  Files           1258     1258           
  Lines          26863    26863           
  Branches        2793     2793           
==========================================
  Hits           11707    11707           
  Misses         13750    13750           
  Partials        1406     1406           
Flag Coverage Δ
unittests 43.58% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sherlockhan Sherlockhan merged commit 0e9a403 into sermant-io:develop Apr 9, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Umbrella issue for translating code comments and documents into English
4 participants