Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version 0.2.2 #9

Merged
merged 3 commits into from
Oct 27, 2022
Merged

Add version 0.2.2 #9

merged 3 commits into from
Oct 27, 2022

Conversation

dcastro
Copy link
Member

@dcastro dcastro commented Oct 25, 2022

Description

Make sure xrefcheck-action supports the recently released xrefcheck v0.2.2

As of this version, xrefcheck now requires git to be installed and available in the PATH.
So the github action will need to be updated to install git beforehand.

After this PR is merged, I'll create a v1.0.3 tag and move the v1 tag to HEAD.

Related issue(s)

None

✅ Checklist for your Pull Request

Related changes (conditional)

  • Documentation

    • I checked whether I should update the docs and did so if necessary:
  • Public contracts

Stylistic guide (mandatory)

@dcastro dcastro requested a review from Sorokin-Anton October 25, 2022 12:33
@dcastro dcastro force-pushed the diogo/add-0.2.2 branch 2 times, most recently from 04391be to 56e8ac4 Compare October 25, 2022 18:26
Problem: As of [v0.2.2](https://github.com/serokell/xrefcheck/releases/tag/v0.2.2),
xrefcheck now requires git to be available in the PATH.

See:
  * serokell/xrefcheck#139
  * serokell/xrefcheck#174

Solution: add `git` as a dependency in the dockerfile.
Problem: We're getting the following warning in the CI:

> Warning: The `set-output` command is deprecated and will be disabled
> soon. Please upgrade to using Environment Files. For more information
> see:
> https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Solution: Stop using `set-output`, start using environment files as
demonstrated in the link above.
@dcastro
Copy link
Member Author

dcastro commented Oct 25, 2022

@gromakovsky can you please confirm this is the correct release process for xrefcheck-action?

After this PR is merged, I'll create a v1.0.3 tag and move the v1 tag to HEAD.


@Sorokin-Anton The CI is now passing, can you have another look please?

Copy link
Member

@gromakovsky gromakovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcastro dcastro merged commit 81d3967 into master Oct 27, 2022
@dcastro dcastro deleted the diogo/add-0.2.2 branch October 27, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants