[temporary] More specific FileSupport type

src/Xrefcheck/Scan.hs

@@ -67,11 +67,17 @@ data ExclusionConfig' f = ExclusionConfig
 
 makeLensesWith postfixFields ''ExclusionConfig'
 
+-- | File extension, dot included.
+type Extension = String
+
+-- | Whether the file is a symlink.
+type IsSymlink = Bool
+
 -- | Way to parse a file.
 type ScanAction = CanonicalPath -> IO (FileInfo, [ScanError 'Parse])
 
 -- | All supported ways to parse a file.
-type FileSupport = CanonicalPath -> IO $ Maybe ScanAction
+type FileSupport = IsSymlink -> Extension -> Maybe ScanAction
 
 data ScanResult = ScanResult
   { srScanErrors :: [ScanError 'Gather]
@@ -218,7 +224,7 @@ scanRepo scanMode rw formatsSupport config root = do
     IncludeUntracked -> pure []
 
   scannableNotProcessedFiles <- liftIO $
-    filterM (fmap isJust . formatsSupport . fst) notProcessedFiles
+    filterM (fmap isJust . fileScanner . fst) notProcessedFiles
 
   whenJust (nonEmpty $ map fst scannableNotProcessedFiles) $ \files -> hPutStrLn @Text stderr
     [int|A|
@@ -238,6 +244,10 @@ scanRepo scanMode rw formatsSupport config root = do
     , riRoot = canonicalRoot
     }
   where
+    fileScanner :: CanonicalPath -> IO (Maybe ScanAction)
+    fileScanner canonicalFile = do
+      isSymlink <- pathIsSymbolicLink canonicalFile
+      pure $ formatsSupport isSymlink $ takeExtension canonicalFile
 
     gatherScanErrs
       :: CanonicalPath
@@ -255,8 +265,8 @@ scanRepo scanMode rw formatsSupport config root = do
 
     processFile :: CanonicalPath -> IO (FileStatus, [ScanError 'Parse])
     processFile canonicalFile = do
-      action <- formatsSupport canonicalFile
-      case action of
+      mScanner <- fileScanner canonicalFile
+      case mScanner of
         Nothing -> pure (NotScannable, [])
         Just scanner -> scanner canonicalFile <&> _1 %~ Scanned
 

src/Xrefcheck/Scanners/Markdown.hs

@@ -419,9 +419,7 @@ markdownScanner config canonicalFile =
     <$> BSL.readFile (unCanonicalPath canonicalFile)
 
 markdownSupport :: MarkdownConfig -> FileSupport
-markdownSupport config path =
-  if takeExtension path /= ".md"
-  then pure Nothing
-  else ifM (pathIsSymbolicLink path)
-    (pure Nothing)
-    (pure (Just $ markdownScanner config))
+markdownSupport config isSymlink extension = do
+  guard $ extension == ".md"
+  guard $ not isSymlink
+  pure $ markdownScanner config

src/Xrefcheck/Scanners/Symlink.hs

@@ -25,7 +25,6 @@ symlinkScanner path = do
   pure (FileInfo [Reference {rName, rLink, rAnchor, rPos, rInfo, rIsSymlink}] [], [])
 
 symlinkSupport :: FileSupport
-symlinkSupport path =
-  ifM (pathIsSymbolicLink path)
-    (pure (Just symlinkScanner))
-    (pure Nothing)
+symlinkSupport isSymlink _ = do
+  guard isSymlink
+  pure symlinkScanner