Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ignored option does not pretend the file doesn't exist #168

Closed
dcastro opened this issue Sep 25, 2022 · 0 comments · Fixed by #174
Closed

[BUG] ignored option does not pretend the file doesn't exist #168

dcastro opened this issue Sep 25, 2022 · 0 comments · Fixed by #174
Assignees
Milestone

Comments

@dcastro
Copy link
Member

dcastro commented Sep 25, 2022

Description

( Original conversation, see the comments in #118 )

The help text for the --ignored option in xrefcheck --help says the following:

Files which we pretend do not exist.

However, this doesn't seem to be true. We do not pretend they don't exist. If a link references that file, we do in fact check that it exists.

To Reproduce

mkdir demo && cd demo
echo "[](b.md)" > a.md
touch b.md
$ xrefcheck --ignored b.md
All repository links are valid.

Expected behavior

Expected xrefcheck to pretend b.md doesn't exist, and report an error in the reference from the a.md file.

Environment

@dcastro dcastro added this to the 0.3 milestone Sep 25, 2022
@dcastro dcastro changed the title [BUG] [BUG] ignored option does not pretend the file doesn't exist Sep 25, 2022
@Sereja313 Sereja313 self-assigned this Sep 26, 2022
Sereja313 added a commit that referenced this issue Oct 21, 2022
@dcastro dcastro modified the milestones: 0.3.0, 0.2.2 Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants