-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for image links #92
Comments
For references that point to images, we will need special care. The current approach to verifying links (load page with |
Oh good point. We can hope that the server will send a chunked response, in which case we only need to wait for the first chunk to inspect the status code (and not look at the response's body at all). We should probably also have a config/CLI option to disable checking images, in case the user's project happens to have a lot of links to heavy images. |
Thinking about this a bit more - maybe they don't need special treatment (nor a flag to disable this check)? I mean, from our point of view, an image link like Since we're on this topic, I also tried this:
And xrefcheck returns almost immediately.
|
Oh really. I initially has an impression, that performing a request usually results in getting the entire response, but in fact most libraries provide a response as a stream, not the entire response at once. And Nice observation. Maybe we don't even need to try the request with |
Problem: We should add support for image links. Solution: Extract image links as regular links.
Problem: We should add support for image links. Solution: Extract image links as regular links.
Problem: We should add support for image links. Solution: Extract image links as regular links.
…mage-links [#92] Add support for image links
Clarification and motivation
We should add support for image links.
Acceptance criteria
xrefcheck
verifies whether image links are valid.The text was updated successfully, but these errors were encountered: