Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#135] CI: add stylish-haskell and shellcheck #144

Merged

Conversation

Sereja313
Copy link
Member

@Sereja313 Sereja313 commented Sep 14, 2022

Description

Problem: We should add stylish-haskell and shellcheck to our pipline.

Solution: Add stylish-haskell and shellcheck. Use stylish-haskell on repo.

Related issue(s)

Fixes #135

✅ Checklist for your Pull Request

Ideally a PR has all of the checkmarks set.

If something in this list is irrelevant to your PR, you should still set this
checkmark indicating that you are sure it is dealt with (be that by irrelevance).

Related changes (conditional)

  • Tests

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from
      silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
  • Public contracts

    • Any modifications of public contracts comply with the Evolution
      of Public Contracts
      policy.
    • I added an entry to the changelog if my changes are visible to the users
      and
    • provided a migration guide for breaking changes if possible

Stylistic guide (mandatory)

@Sereja313 Sereja313 force-pushed the Sereja313/#135-ci-add-stylish-haskell-and-shellcheck branch from 9ed9c54 to 4960e4f Compare September 15, 2022 19:51
@Sereja313 Sereja313 marked this pull request as ready for review September 15, 2022 19:54
@dcastro dcastro changed the base branch from master to Sereja313/#134-add-makefile September 17, 2022 16:21
@dcastro
Copy link
Member

dcastro commented Sep 17, 2022

I changed the base branch for this PR from master to Sereja313/#134-add-makefile.

Approved, but let's not merge this yet

@Sereja313 Sereja313 force-pushed the Sereja313/#134-add-makefile branch 2 times, most recently from 000172c to 1543744 Compare September 27, 2022 08:33
Problem: We should add stylish-haskell and shellcheck to our pipline.

Solution: Add stylish-haskell and shellcheck. Use stylish-haskell on repo.
@Sereja313 Sereja313 force-pushed the Sereja313/#135-ci-add-stylish-haskell-and-shellcheck branch from 4960e4f to c94ddfc Compare September 27, 2022 09:05
Base automatically changed from Sereja313/#134-add-makefile to master September 27, 2022 11:51
@Sereja313 Sereja313 merged commit 01235c6 into master Sep 27, 2022
@Sereja313 Sereja313 deleted the Sereja313/#135-ci-add-stylish-haskell-and-shellcheck branch September 27, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: add stylish-haskell and shellcheck
3 participants