[Chore] Replace buildkite ci with github-actions #267
Conversation
Generated by 🚫 Danger |
PhilTaken
force-pushed
the
philtaken/replace-buildkite
branch
from
c07bd1e to
63f53eb
Compare
PhilTaken
changed the title
|
I propose to rebase this on top of #258 and merge this PR afterwards |
PhilTaken
force-pushed
the
philtaken/replace-buildkite
branch
from
59fca08 to
a31d78f
Compare
PhilTaken
force-pushed
the
philtaken/replace-buildkite
branch
2 times, most recently
from
2d2bd78 to
b279861
Compare
|
@rvem there are a bunch of license notices still mentioning 2022, should I update them? I just rebased the pr onto master |
|
Now why does xrefcheck fail 🤔 I didn't change anything about those files |
rvem
force-pushed
the
philtaken/replace-buildkite
branch
2 times, most recently
from
ea8f514 to
53b6672
Compare
.github/workflows/autorelease.yml
Outdated
| run: | | ||
| nix build -L .#docker-image | ||
| nix shell .#skopeo -c ./scripts/upload-docker-image.sh "docker-archive:$(readlink result)" "docker://docker.io/serokell/xrefcheck:latest" | ||
|
|
There was a problem hiding this comment.
| path: result/bin/xrefcheck | ||
|
|
||
| - name: Xrefcheck itself | ||
| run: nix run . -L |
There was a problem hiding this comment.
We had
retry:
automatic:
limit: 2
for it
There was a problem hiding this comment.
Ugh, nick-fields/retry@v2.8.3 doesn't work well with nix:(
There was a problem hiding this comment.
Does it mean there is no way for us to configure some step to automatically retry N times?
There was a problem hiding this comment.
I think there is a way, but this will require some additional research to fix but I didn't want to spend too much time on this right now:(
rvem
force-pushed
the
philtaken/replace-buildkite
branch
3 times, most recently
from
3d2cce9 to
7dab3af
Compare
They seem to be quite old and cause
rvem
force-pushed
the
philtaken/replace-buildkite
branch
from
7dab3af to
b3c67d4
Compare
| steps: | ||
| - uses: actions/checkout@v3 | ||
| with: | ||
| submodules: true |
There was a problem hiding this comment.
What does it mean? Do we have submodules?
There was a problem hiding this comment.
Yes, several libraries for bats:
https://github.com/serokell/xrefcheck/tree/master/tests/golden/helpers
|
Seems like I need to recreate PR to disable the buildkite check |
Description
Related issue(s)
Fixes #
✅ Checklist for your Pull Request
Ideally a PR has all of the checkmarks set.
If something in this list is irrelevant to your PR, you should still set this
checkmark indicating that you are sure it is dealt with (be that by irrelevance).
Related changes (conditional)
Tests
silently reappearing again.
Documentation
Public contracts
of Public Contracts policy.
and
Stylistic guide (mandatory)
✓ Release Checklist
package.yaml.under the "Unreleased" section to a new section for this release version.
vX.Y.Z.xrefcheck-action.