feat(packager): add noInstall option (#1003)

* feat(packager): add noInstall option

Co-authored-by: Russell Anthony <russell@kingsmen.cc>

README.md

@@ -371,7 +371,11 @@ configuration setting. For details see below.
 By default, the plugin uses NPM to package the external modules. However, if you use npm,
 you should use any version `<5.5 >=5.7.1` as the versions in-between have some nasty bugs.
 
-Right now there are no `packagerOptions` that can be set with NPM.
+The NPM packager supports the following `packagerOptions`:
+
+| Option             | Type | Default | Description                                         |
+| ------------------ | ---- | ------- | --------------------------------------------------- |
+| noInstall          | bool | false   | Do not run `npm install` (assume install completed) |
 
 ##### Yarn
 
@@ -382,6 +386,7 @@ The yarn packager supports the following `packagerOptions`:
 | Option             | Type | Default | Description                                         |
 | ------------------ | ---- | ------- | --------------------------------------------------- |
 | ignoreScripts      | bool | false   | Do not execute package.json hook scripts on install |
+| noInstall          | bool | false   | Do not run `yarn install` (assume install completed)|
 | noFrozenLockfile   | bool | false   | Do not require an up-to-date yarn.lock              |
 | networkConcurrency | int  |         | Specify number of concurrent network requests       |
 

lib/packagers/npm.js

@@ -103,7 +103,11 @@ class NPM {
     return lockfile;
   }
 
-  static install(cwd) {
+  static install(cwd, packagerOptions) {
+    if (packagerOptions.noInstall) {
+      return BbPromise.resolve();
+    }
+
     const command = /^win/.test(process.platform) ? 'npm.cmd' : 'npm';
     const args = ['install'];
 

lib/packagers/npm.test.js

@@ -49,7 +49,7 @@ describe('npm', () => {
   describe('install', () => {
     it('should use npm install', () => {
       Utils.spawnProcess.returns(BbPromise.resolve({ stdout: 'installed successfully', stderr: '' }));
-      return expect(npmModule.install('myPath')).to.be.fulfilled.then(result => {
+      return expect(npmModule.install('myPath', {})).to.be.fulfilled.then(result => {
         expect(result).to.be.undefined;
         expect(Utils.spawnProcess).to.have.been.calledOnce;
         expect(Utils.spawnProcess).to.have.been.calledWithExactly(sinon.match(/^npm/), ['install'], {
@@ -60,6 +60,16 @@ describe('npm', () => {
     });
   });
 
+  describe('noInstall', () => {
+    it('should skip npm install', () => {
+      return expect(npmModule.install('myPath', { noInstall: true })).to.be.fulfilled.then(result => {
+        expect(result).to.be.undefined;
+        expect(Utils.spawnProcess).not.to.have.been.called;
+        return null;
+      });
+    });
+  });
+
   describe('prune', () => {
     it('should use npm prune', () => {
       Utils.spawnProcess.returns(BbPromise.resolve({ stdout: 'success', stderr: '' }));

lib/packagers/yarn.js

@@ -118,6 +118,10 @@ class Yarn {
   }
 
   static install(cwd, packagerOptions) {
+    if (packagerOptions.noInstall) {
+      return BbPromise.resolve();
+    }
+
     const command = /^win/.test(process.platform) ? 'yarn.cmd' : 'yarn';
     const args = [ 'install', '--non-interactive' ];
 

lib/packagers/yarn.test.js

@@ -276,6 +276,15 @@ describe('yarn', () => {
     });
   });
 
+  describe('noInstall', () => {
+    it('should skip yarn install', () => {
+      return expect(yarnModule.install('myPath', { noInstall: true })).to.be.fulfilled.then(result => {
+        expect(result).to.be.undefined;
+        return null;
+      });
+    });
+  });
+
   describe('prune', () => {
     let installStub;