-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new packagerOptions
: noNonInteractive
to disable interactive mode when using Yarn 2 or above
#1246
Add new packagerOptions
: noNonInteractive
to disable interactive mode when using Yarn 2 or above
#1246
Conversation
…when using Yarn 2 or above
packagerOptions
: noNonInteractive
to disable interactive mode when using Yarn 2 or above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me.
I'm wondering if this kind of option could be "transparent" without too much overload, like we check Yarn version and if the version < 2, we apply the --non-interactive
option.
Interesting idea, let me have a look at that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in its current state, I also quite like the transparent idea.
Sidenote:
- If version detection for yarn is possible,
--frozen-lockfile
option should be translated to--immutable
. - If even more arguments are found diverging between v1 and v2, we may have to split it out to a new file e.g.
lib/packagers/yarn-berry.js
@jagonzalr Yep, we'll merge it and if you want to work on an improved version, we'll be happy to review it 👍🏼 |
Is there a known timeline for this update to be published to npm? Thanks ❤️ |
In the coming days I guess |
What did you implement:
Closes #642
How did you implement it:
Add a new flag
noNonInteractive
topackagerOptions
when usingyarn
as thepackager
.If using Yarn 2 or above the flag
--non-interactive
will breakyarn install
.How can we verify it:
npm run test
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO