Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore handlers that do not follow a path pattern #196

Merged
merged 1 commit into from
Aug 21, 2017

Conversation

HyperBrain
Copy link
Member

@HyperBrain HyperBrain commented Aug 20, 2017

What did you implement:

Closes #193

How did you implement it:

Ignore handlers in automatic handler resolution that do not follow the handler.func pattern.
This is the case for all Google handlers.

How can we verify it:

Use Serverless with the google-cloudfunctions plugin. Package the project and see if it succeeds.

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors (not yet implemented)
  • Make sure code coverage hasn't dropped (not yet implemented)
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@HyperBrain HyperBrain changed the base branch from master to v2.x August 20, 2017 15:20
@HyperBrain
Copy link
Member Author

@huysamen Can you check with this branch, if it works for you now?

Just reference the plugin as follows in your package.json:

"serverless-webpack": "github:elastic-coders/serverless-webpack#handle-entry-detection-for-malformed-handlers"

Please let me know and I will merge the fix and release a 2.2.1 bugfix version

@huysamen
Copy link

@HyperBrain yeah that seems to have fixed the issue, thanks!

@HyperBrain HyperBrain force-pushed the handle-entry-detection-for-malformed-handlers branch from bad6306 to 5916a90 Compare August 21, 2017 10:17
@HyperBrain HyperBrain merged commit 247b649 into v2.x Aug 21, 2017
@HyperBrain HyperBrain deleted the handle-entry-detection-for-malformed-handlers branch August 21, 2017 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants