-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Developer Experience #496
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should configure prettier exactly the same way as eslint. Your setting
seems to be a bit different
Hassan Khan <notifications@github.com> schrieb am Sa., 27. Apr. 2019, 1:31
vorm.:
… @hassankhan <https://github.com/hassankhan> requested your review on: #496
<#496>
Improve Developer Experience.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#496 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABKEZXSBJATNKYXSJ5RYUYLPSOGEZANCNFSM4HI2YGGQ>
.
|
Thanks for looking over it, @HyperBrain 👍 I've updated everything except the |
HyperBrain
requested changes
Apr 30, 2019
HyperBrain
approved these changes
May 2, 2019
Feel free to get this in as soon as you are finished 👍 |
Merged
jamesmbourne
pushed a commit
to jamesmbourne/serverless-webpack
that referenced
this pull request
Oct 15, 2019
Improve Developer Experience
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Set up Git hooks to run linters/tests on a Git
pre-commit
hook.How did you implement it:
Added
husky
,prettier
andlint-staged
and relevant configuration files.How can we verify it:
Branch from this PR and try committing a change to any
.js
file.Todos:
Write testsWrite documentationIs this ready for review?: YES
Is it a breaking change?: NO