Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Developer Experience #496

Merged
merged 1 commit into from
May 2, 2019

Conversation

hassankhan
Copy link
Contributor

@hassankhan hassankhan commented Apr 26, 2019

What did you implement:

Set up Git hooks to run linters/tests on a Git pre-commit hook.

How did you implement it:

Added husky, prettier and lint-staged and relevant configuration files.

How can we verify it:

Branch from this PR and try committing a change to any .js file.

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@HyperBrain
Copy link
Member

HyperBrain commented Apr 27, 2019 via email

@hassankhan
Copy link
Contributor Author

Thanks for looking over it, @HyperBrain 👍 I've updated everything except the trailingComma option because I wanted to ask if you would be open to allowing trailing commas?

package.json Outdated Show resolved Hide resolved
prettier.config.js Show resolved Hide resolved
@HyperBrain HyperBrain modified the milestones: 5.3.0, 5.3.1 Apr 30, 2019
@HyperBrain
Copy link
Member

Feel free to get this in as soon as you are finished 👍

@hassankhan hassankhan merged commit fc2cffd into serverless-heaven:master May 2, 2019
@hassankhan hassankhan deleted the improve-dx branch May 2, 2019 22:03
jamesmbourne pushed a commit to jamesmbourne/serverless-webpack that referenced this pull request Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants