Skip to content
This repository has been archived by the owner on Jan 28, 2025. It is now read-only.

fix(core): render static pages for all http methods, for options meth… #2024

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Nov 8, 2021

…ods return allowed methods. This will be in parity with Next.js server as it also renders static pages no matter the request method. Note: only applies if S3 pages are rendered through the Lambda, as for CloudFront -> s3 origin, http method cannot be modified (and we don't want to do it in origin response handler as it will just be inefficient).

@slsnextbot
Copy link
Collaborator

slsnextbot commented Nov 8, 2021

Handler Size Report

There are changes to handler sizes. Please review.

Base Handler Sizes (kB) (commit 6d761ff)

{
    "Lambda": {
        "Default Lambda": {
            "Standard": 1519,
            "Minified": 666
        },
        "Image Lambda": {
            "Standard": 1484,
            "Minified": 800
        }
    },
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1529,
            "Minified": 672
        },
        "Default Lambda V2": {
            "Standard": 1521,
            "Minified": 668
        },
        "API Lambda": {
            "Standard": 632,
            "Minified": 318
        },
        "Image Lambda": {
            "Standard": 1492,
            "Minified": 805
        },
        "Regeneration Lambda": {
            "Standard": 1182,
            "Minified": 543
        },
        "Regeneration Lambda V2": {
            "Standard": 1251,
            "Minified": 571
        }
    }
}

New Handler Sizes (kB) (commit ad7b29b)

{
    "Lambda": {
        "Default Lambda": {
            "Standard": 1519,
            "Minified": 666
        },
        "Image Lambda": {
            "Standard": 1485,
            "Minified": 800
        }
    },
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1529,
            "Minified": 672
        },
        "Default Lambda V2": {
            "Standard": 1521,
            "Minified": 668
        },
        "API Lambda": {
            "Standard": 632,
            "Minified": 318
        },
        "Image Lambda": {
            "Standard": 1493,
            "Minified": 805
        },
        "Regeneration Lambda": {
            "Standard": 1183,
            "Minified": 544
        },
        "Regeneration Lambda V2": {
            "Standard": 1251,
            "Minified": 571
        }
    }
}

@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #2024 (ad7b29b) into master (6d761ff) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2024   +/-   ##
=======================================
  Coverage   83.86%   83.86%           
=======================================
  Files         102      102           
  Lines        3626     3626           
  Branches     1139     1139           
=======================================
  Hits         3041     3041           
  Misses        574      574           
  Partials       11       11           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d761ff...ad7b29b. Read the comment docs.

@dphang
Copy link
Collaborator Author

dphang commented Nov 9, 2021

Transient test failure

@dphang dphang merged commit 9fe3216 into master Nov 9, 2021
@dphang dphang deleted the dphang--fix-methods branch November 9, 2021 00:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants