feat: normalise trailing slashes #448
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@afzalsayed96 The aim of this project is to follow closely Next.js server features, especially routing. Departing from that core idea it's something I want to avoid. Feel free to reopen once the PR referenced is merged 👍 |
|
@afzalsayed96 @danielcondemarin The PR vercel/next.js#13333 has been merged. Could you re-open please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #249 was closed. This is a much needed feature. Next.js is working on this here: vercel/next.js#13333 but it seems to be taking long. It would be really nice if we can support this in the component.
Details
If a page exists on
example.com/aboutthen visitingexample.com/about/returns 404 Not found error. This PR normalises paths with trailing slashes such thatexample.com/about/resolves toexample.com/about.