-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: mixing runtimes and architectures #815
fix: mixing runtimes and architectures #815
Conversation
cc: @pgrzesik - would be great if you could take a look whenever time permits! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @stijzermans 🙇 Great improvements 👏 Let's make sure the tests are passing and we should be good to go here 👍
@@ -185,6 +180,18 @@ class ServerlessPythonRequirements { | |||
this.commands.requirements.type = 'container'; | |||
} | |||
|
|||
this.dockerImageForFunction = (funcOptions) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…erless#815) * feat: Use function runtime & arch for docker * docs: Update readme for python3.9 * feat: Do not zip req for non-py functions * ci: Bump internal package version / python version * fix: Rename mixed test name to be more descriptive --------- Co-authored-by: Stijn IJzermans <stijn@headfwd.com>
while running a setup where combining Python and NodeJS lambda's, I ran into a couple of issues:
dockerizePip
image would always default to provider.runtime / provider.architecturewhich would lead to the following error:
therefore I've adjusted
zipping to be to only be performed on either functions which runtimes are specifically python, or no runtime is set and
provider.runtime
is python3.to take function options as argument for retrieving the docker image.