Basic logging for python invoke local #4429
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #4147
This affects both Python 2.7 and Python 3.6 when you try to use
logging
.How did you implement it:
Just force
logging
module to provide a basic config, check logging.basicConfig. Worthy to mention:How can we verify it:
YAML:
handler.py
Invoking
sls invoke local -f hello
, before:after:
With Python 3.6 (changing
serverless.yml
) it fails silently, before:after:
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO