Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve integration test of aws-scala-sbt #6079

Merged
merged 1 commit into from
May 6, 2019
Merged

Improve integration test of aws-scala-sbt #6079

merged 1 commit into from
May 6, 2019

Conversation

NomadBlacky
Copy link

What did you implement:

Closes #XXXXX

How did you implement it:

  • Specified docker image version of hseeberger/scala-sbt.
    • Before: Download sbt and Scala every execution because does not match versions between the docker image and aws-scala-sbt template.

How can we verify it:

  • $ tests/templates/integration-test-template aws-scala-sbt sbt assembly

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@pmuens pmuens self-assigned this May 6, 2019
pmuens
pmuens approved these changes May 6, 2019
View reviewed changes
Copy link
Contributor

@pmuens pmuens left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit: Thanks @NomadBlacky! 👍

@pmuens pmuens merged commit c07e7e1 into serverless:master May 6, 2019
@pmuens pmuens added cat/dx and removed cat/template labels May 6, 2019
@pmuens pmuens added this to the 1.42.0 milestone May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmuens pmuens pmuens approved these changes

Assignees

@pmuens pmuens

Labels
cat/dx enhancement
Projects
None yet
Milestone
1.42.0
Development

Successfully merging this pull request may close these issues.
2 participants
@NomadBlacky @pmuens