-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
address merge conflicts and code quality issues #122
address merge conflicts and code quality issues #122
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
==========================================
+ Coverage 84.18% 86.96% +2.77%
==========================================
Files 20 32 +12
Lines 1865 3405 +1540
==========================================
+ Hits 1570 2961 +1391
- Misses 295 444 +149
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d8b1297
to
1abe57f
Compare
@davegarred this should help resolve the build issues in the other PRs once this is merged I'll need to rebase those before any further PRs are merged (i've marked them all as 'drafts' so it's clear) |
If it helps, you can configure the repo to disallow merging PRs that are not up-to-date with |
Very nice, thank you! |
there were some issues introduced by merging all those PRs without rebasing in between. This PR addresses those