Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WorkflowCompletedEventV1 by adding a new output property #398

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Fix WorkflowCompletedEventV1 by adding a new output property #398

merged 3 commits into from
Sep 10, 2024

Conversation

cdavernas
Copy link
Member

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:

  • Fixes the WorkflowCompletedEventV1 by adding a new output property
  • Fixes all runtimes to set both the runner's NAMESPACE and NAME environment variables
  • Fixes all container platforms to name spawned containers after both the runner and their image
  • Fixes the ContainerTaskExecutor by removing output truncation when using Kubernetes
  • Fixes the KubernetesContainer by fixing the WaitForExit method
  • Changed the Nuget package name to Synapse to avoid collision with a package from another company

Closes #396

@cdavernas
fix(Core): Fixed the WorkflowCompletedEventV1 by adding a new `Output…
f2ace89 
…` property

fix(Runtimes): Fixed all runtimes to set both the runner's `NAMESPACE` and `NAME` environment variables
fix(ContainerPlatforms): Fixed all container platforms to name spawned containers after both the runner and their image
fix(Runner): Fixed the ContainerTaskExecutor by removing output truncation when using Kubernetes
fix(KubernetesContainerPlatform): Fixed the KubernetesContainer by fixing the WaitForExit method

Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
@cdavernas
fix(Solution): Minor fixes and improvements
6d9bc18 
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
@cdavernas
fix(Core): Changed the Nuget package name to Synapse to avoid collisi…
1200eac 
…on with a package from another company

Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
@cdavernas cdavernas added priority: high Indicates a high priority issue runtime: docker Concerns the Docker Runtime Host app: api Concerns the API weight: 2 An issue with a low development impact app: runner Concerns the Runner runtime: native Concerns the native runtime host runtime: kubernetes Concerns the Kubernetes runtime host type: fix labels Sep 10, 2024
@cdavernas cdavernas added this to the v1.0.0 milestone Sep 10, 2024
@cdavernas cdavernas self-assigned this Sep 10, 2024
@cdavernas cdavernas merged commit b860edb into main Sep 10, 2024
4 checks passed
@cdavernas cdavernas deleted the fix-workflow-completed-event-output branch September 11, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cdavernas cdavernas

Labels
app: api Concerns the API app: runner Concerns the Runner priority: high Indicates a high priority issue runtime: docker Concerns the Docker Runtime Host runtime: kubernetes Concerns the Kubernetes runtime host runtime: native Concerns the native runtime host type: fix weight: 2 An issue with a low development impact
Projects
Progress Tracker
Status: Done
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

Add output data to completed event
1 participant
@cdavernas