Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample using External Secrets Operator #273

Merged
merged 3 commits into from
May 23, 2023

Conversation

scothis
Copy link
Contributor

@scothis scothis commented May 2, 2023

External Secrets Operator (ESO) is a way to synthesize Kubernetes Secrets from secure data stores. There is a PR that adds provisioned service support to ExternalSecret resources.

This sample is intended to facilitate the conversation between the Service Bindings and External Secrets communities. This PR should not be merged unless and until the update PR lands.

Refs external-secrets/external-secrets#2263

External Secrets Operator (ESO) is a way to synthesize Kubernetes
Secrets from secure data stores. There is a PR that adds provisioned
service support to ExternalSecret resources.

This sample is intended to facilitate the conversation between the
Service Bindings and External Secrets communities. This PR should not be
merged unless and until the update PR lands.

Refs external-secrets/external-secrets#2263

Signed-off-by: Scott Andrews <andrewssc@vmware.com>
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8dcf17e) 81.80% compared to head (52e0058) 81.80%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #273   +/-   ##
=======================================
  Coverage   81.80%   81.80%           
=======================================
  Files          15       15           
  Lines        1451     1451           
=======================================
  Hits         1187     1187           
  Misses        217      217           
  Partials       47       47           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@scothis
Copy link
Contributor Author

scothis commented May 3, 2023

Readable view

Signed-off-by: Scott Andrews <andrewssc@vmware.com>
Signed-off-by: Scott Andrews <andrewssc@vmware.com>
@scothis scothis marked this pull request as ready for review May 22, 2023 18:50
@scothis scothis requested a review from a team May 22, 2023 18:50
@scothis scothis requested a review from sadlerap May 23, 2023 13:06
Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sadlerap sadlerap merged commit 0e4f2d8 into servicebinding:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants