Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from VMware implementation #336

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

scothis
Copy link
Contributor

@scothis scothis commented Sep 9, 2023

Hooks to migrate from the VMware implementation are available opt-in by
passing the --migrate-from-vmware flag to the manager container. Running
with the migration hooks installed will incur a performance penalty and
should only be used while a migration is active, and then disabled.

Depends on #327

@scothis scothis requested a review from a team September 9, 2023 19:57
@scothis scothis mentioned this pull request Sep 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2023

Codecov Report

Patch coverage: 55.20% and project coverage change: -3.09% ⚠️

Comparison is base (30c9c68) 81.44% compared to head (fc818cc) 78.36%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
- Coverage   81.44%   78.36%   -3.09%     
==========================================
  Files          17       19       +2     
  Lines        1450     1627     +177     
==========================================
+ Hits         1181     1275      +94     
- Misses        221      281      +60     
- Partials       48       71      +23     
Files Changed Coverage Δ
dies/v1beta1/servicebinding.go 0.00% <0.00%> (ø)
controllers/webhook_controller.go 82.75% <11.11%> (-4.84%) ⬇️
lifecycle/hooks.go 40.00% <40.00%> (ø)
controllers/servicebinding_controller.go 84.61% <40.74%> (-7.52%) ⬇️
lifecycle/vmware/migration.go 66.41% <66.41%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to assume the hooks are correct, since I don't know enough about vmware's implementation to know if they're correct or not.

Got one small question, otherwise LGTM.

Makefile Show resolved Hide resolved
Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just waiting on ci

Hooks to migrate from the VMware implementation are available opt-in by
passing the --migrate-from-vmware flag to the manager container. Running
with the migration hooks installed will incur a performance penalty and
should only be used while a migration is active, and then disabled.

Signed-off-by: Scott Andrews <andrewssc@vmware.com>
@sadlerap sadlerap merged commit 22c56eb into servicebinding:main Sep 14, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants