Update to criterion 0.5 #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specify the current version of the benchmarking framework to address cargo audit warnings about the dependencies of earlier releases. Note that this requires rust 1.74.1 or later to run `cargo bench` but MSRV (1.60.0) is only gated against the library target itself and not dev-dependencies, so this is no change in the requirements on downstream users.
mrobinson
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify the current version of the benchmarking framework to address cargo audit warnings about the dependencies of earlier releases.
Note that this requires rust 1.74.1 or later to run
cargo benchbut MSRV (1.60.0) is only gated against the library target itself and not dev-dependencies, so this is no change in the requirements on downstream users.