Only check attributes of current tag for duplicates. #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdm
force-pushed
the
xml-attrs
branch
2 times, most recently
from
26bbbf0 to
44a9110
Compare
|
Depends on #540 to get rid of unrelated CI errors. |
|
I verified this fix locally, it fixes the issue of missing attributes. |
nicoburns
approved these changes
Jun 5, 2024
I prefer the clarity of the current implementation. I'd be willing to change it if there's evidence that it's a performance gap that matters to a user, but I think that could be a followup. |
|
This caused 29 tests to start passing in Servo! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #538. The current implementation never clears the
present_attrsfield so each unique pair of namespace and local names can only appear once in an XML document. The intent of the implementation is to exclude any attributes that resolve to a duplicate qualified name within a tag, so there is no need to store the hashset as a persistent field of the tree builder.