Skip to content

Commit

Permalink
ci: Make it so that the workflow fails is any job fails (#349)
Browse files Browse the repository at this point in the history
This is the same setup we have in other Servo repositories.
  • Loading branch information
mrobinson authored Jul 30, 2024
1 parent 6aa857c commit 24eee8a
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,16 +85,17 @@ jobs:
build_result:
name: Result
runs-on: ubuntu-latest
if: always()
needs:
- "linux-ci"
- "mac-ci"
- "windows-ci"

steps:
- name: Mark the job as successful
- name: Success
run: exit 0
if: success()
- name: Mark the job as unsuccessful
if: ${{ !contains(needs.*.result, 'failure') && !contains(needs.*.result, 'cancelled') }}
- name: Failure
run: exit 1
if: "!success()"
if: contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled')

0 comments on commit 24eee8a

Please sign in to comment.