-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust 2018 syntax and misc updates #280
Conversation
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @emilio (or someone else) soon. |
☔ The latest upstream changes (presumably #284) made this pull request unmergeable. Please resolve the merge conflicts. |
|
I think this can be closed, unless there are some other improvements in this PR? |
It looks like the removal of the use of |
In this PR i wanted to take advantage of the idioms of Rust 2018, update the dependecies to the latest public version and remove deprecated code.
crossbeam-channel
updated from0.4
to0.5
.rand
from0.7
to0.8
.crossbeam-utils
from0.7
to0.8
.extern crate
and#[macro_use]
syntax, replaced byuse
where it's needed.std::mem::replace
withstd::mem::take
.unsafe fn
] Replaced the decprecatedmem::uninitialized
withmem::MaybeUninit::uninit()
.unsafe
code block] Replacedptr.offset(offset as isize)
withptr.add(offset)
. relative clippy lintTested with:
cargo +nightly build --release --all-features --all-targets
cargo +nightly test --all-features --all-targets
cargo +nightly bench --all-features --all-targets
I didn't formatted the code with
cargo fmt
because it would have brought too much changes, if necessary I'm ready to send a new patch.