Remove usage of unstable features #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `static_assertions::assert_not_impl_any` to assert that OsIpcSender doesn't implement Sync instead of relying on unstable rustc features. This also makes it clearer what this code does.
mrobinson
force-pushed
the
remove-unstable
branch
from
02ca8b8 to
d579662
Compare
jdm
approved these changes
Nov 15, 2023
mrobinson
added a commit
that referenced
this pull request
Nov 16, 2023
Use `static_assertions::assert_not_impl_any` to assert that OsIpcSender doesn't implement Sync instead of relying on unstable rustc features. This also makes it clearer what this code does.
mrobinson
added a commit
that referenced
this pull request
Nov 16, 2023
Use `static_assertions::assert_not_impl_any` to assert that OsIpcSender doesn't implement Sync instead of relying on unstable rustc features. This also makes it clearer what this code does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
static_assertions::assert_not_impl_anyto assert that OsIpcSenderdoesn't implement Sync instead of relying on unstable rustc features.
This also makes it clearer what this code does.