Remove windows-shared-memory-equality feature
#364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrobinson
force-pushed
the
remove-shared-memory-equality-feature
branch
2 times, most recently
from
1b86628 to
cd311a8
Compare
mrobinson
force-pushed
the
remove-shared-memory-equality-feature
branch
from
cd311a8 to
3433c8d
Compare
This feature is useful because it allows compiling for versions of Windows older than Windows 10. Windows 10 was released about a decade ago, so I think it's fine to remove support for older versions of Windows. For example Windows 7 is no longer supported as of January 2020 and it seems that less than 3% of users are using it.
mrobinson
force-pushed
the
remove-shared-memory-equality-feature
branch
from
3433c8d to
051381f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is useful because it allows compiling for versions of
Windows older than Windows 10. Windows 10 was released about a decade
ago, so I think it's fine to remove support for older versions of
Windows. For example Windows 7 is no longer supported as of January 2020
and it seems that less than 3% of users are using it.